Re: Single transaction in the tablesync worker?
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-02T06:51:35Z
Lists: pgsql-hackers
Attachments
- v24-Testing-broken-connection-20210202.txt (text/plain)
On Mon, Feb 1, 2021 at 11:26 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > I have updated the patch to display WARNING for each of the tablesync > slots during DropSubscription. As discussed, I have moved the drop > slot related code towards the end in AlterSubscription_refresh. Apart > from this, I have fixed one more issue in tablesync code where in > after catching the exception we were not clearing the transaction > state on the publisher, see changes in LogicalRepSyncTableStart. ... I know that in another email [ac0202] Ajin has reported some problem he found related to this new (LogicalRepSyncTableStart PG_CATCH) code for some different use-case, but for my test scenario of a "broken connection during a table copy" the code did appear to be working properly. PSA detailed logs which show the test steps and output for this ""broken connection during a table copy" scenario. ---- [ac0202] https://www.postgresql.org/message-id/CAFPTHDaZw5o%2BwMbv3aveOzuLyz_rqZebXAj59rDKTJbwXFPYgw%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
Commits
-
Fix relcache reference leak introduced by ce0fdbfe97.
- 8a4f9522d0c7 14.0 landed
-
Fix Subscription test added by commit ce0fdbfe97.
- c8b21b037814 14.0 landed
-
Allow multiple xacts during table sync in logical replication.
- ce0fdbfe9722 14.0 landed
-
Logical replication support for initial data copy
- 7c4f52409a8c 10.0 cited