Re: Add support for specifying tables in pg_createsubscriber.

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Shubham Khanna <khannashubham1197@gmail.com>

Cc: Chao Li <li.evan.chao@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-08T06:05:14Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Support existing publications in pg_createsubscriber.
- 85ddcc2f4cde 19 (unreleased) landed

Hi Shubham,

Another review comment about patch v14...

While reviewing pg_createsubscriber logs, I was surprised to see some
almost duplicate consecutive logs for the pub/slot creation. e.g.
----------
pg_createsubscriber: creating publication "pub2" in database "db2"
pg_createsubscriber: create publication "pub2" in database "db2"
----------

I found the code is doing:
- pg_log_info("creating publication...") unconditionally inside
create_publication
- pg_log_info("create publication...") immediately after call to
create_publication

(patch fragment)
+ create_publication(conn, &dbinfo[i]);
+ pg_log_info("create publication \"%s\" in database \"%s\"",
+ dbinfo[i].pubname, dbinfo[i].dbname);

I think the logging *after* the call is redundant and should be removed.

======
Kind Regards,
Peter Smith.
Fujitsu Australia