Thread

Re: Support EXCEPT for ALL SEQUENCES publications

Peter Smith <smithpb2250@gmail.com> — 2026-05-25T07:37:22Z

Hi Shlok -

I wonder if it might be worth reconsidering the split between patches
0001 and 0002. My understanding is that the only reason for splitting
is to make review easier, but it had the opposite effect for me.

The difficulty is that 0001 contains renaming of functions and
variables whose purpose only becomes clear in 0002. Without any
context, the changes in 0001 are hard to evaluate on their own merits
— anybody reading patch 0001 is left guessing what is coming rather
than seeing the full picture.

It also won't be saving much overall patch size, since AFAICT most of
the same locations are touched again in 0002 anyway.

There is also the matter of identifier renames (patch 0001) being
separated from their associated comment updates (0002). Keeping those
together would reduce the risk of anything being inadvertently missed.

I think a combined 0001/0002 patch would be easier to follow, since
reviewers could see each change alongside its reason.

======
Kind Regards
Peter Smith.
Fujitsu Australia