Re: Enumize logical replication message actions

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-11-25T08:56:24Z

Lists: pgsql-hackers

Attachments

v1-0001-Enums-for-message-types.patch (application/octet-stream) patch v1-0001

Hi Hackers.

Last month there was a commit [1] for replacing logical replication
message type characters with enums of equivalent values.

I was revisiting this code recently and I think due to oversight that
initial patch was incomplete. IIUC there are several more enum
substitutions which should have been made.

PSA my patch which adds those missing substitutions.

---

[1] https://github.com/postgres/postgres/commit/644f0d7cc9c2cb270746f2024c706554e0fbec82

Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Use Enums for logical replication message types at more places.
- f3a8f73ec274 14.0 landed
Use Enum for top level logical replication message types.
- 644f0d7cc9c2 14.0 landed