Re: Pgoutput not capturing the generated columns

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi.shinoda@hpe.com>, vignesh C <vignesh21@gmail.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>
Date: 2025-01-12T23:55:24Z
Lists: pgsql-hackers

Attachments

Hi,

Some patches of this thread have fallen though the cracks for more
than 2 months now, so I am re-posting them so that do not get
overlooked any longer.

For v49 [1] there were 2 patches:
v49-0001-Enable-support-for-publish_generated_columns-par
v49-0002-DOCS-Generated-Column-Replication

Then, at v50 [2] there were 2 patches:
v50-0001-Replicate-generated-columns-when-publish_generat
v50-0002-Tap-tests-for-generated-columns

Notice the DOCS patch is missing in v50.

Those v50* patches were then pushed to master. But, that was 2 months ago.

~~

So, the v49-0002-DOCS patch (which added a new section to Chapter 29)
remains still unpushed.

Meanwhile, it was reported [3] that pubgencols attribute of the
pg_publication catalog is missing from the docs.

~~

In this post, I have attached v51* patches where:

v51-0001 - This is a rebase of the missing DOCS patch from v49.

v51-0002 - This is the pg_publication catalog missing pubgencols
attribute patch.

~~~

Future -- there probably need to be further clarifications/emphasis to
describe how the generated column replication feature only works for
STORED generated columns (not VIRTUAL ones), but IMO it is better to
address that separately *after* dealing with these missing
documentation patches.

======
[1] v49 - https://www.postgresql.org/message-id/CALDaNm3XV5mAeZzZMkOPSPieANMaxOH8xAydLqf8X5PQn%2Ba5EA%40mail.gmail.com
[2] v50 - https://www.postgresql.org/message-id/CALDaNm1hR9-xFZXiK0it_ohn%2BPvfKTLvoOFhBi7p9oTSRCPJRg%40mail.gmail.com
[3] pg_publication -
https://www.postgresql.org/message-id/DM4PR84MB1734D79B25D5B427F5B6101AEE5C2%40DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM

Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.