Re: pg_createsubscriber --dry-run logging concerns

Peter Smith <smithpb2250@gmail.com>

From: Peter Smith <smithpb2250@gmail.com>

To: Euler Taveira <euler@eulerto.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, Álvaro Herrera <alvherre@kurilemu.de>, Chao Li <li.evan.chao@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-06-29T20:21:39Z

Lists: pgsql-hackers

On Tue, Jun 30, 2026 at 8:15 AM Euler Taveira <euler@eulerto.com> wrote:
>
> On Mon, Jun 29, 2026, at 10:56 AM, Peter Eisentraut wrote:
> >
> > I have a follow-up for this.  Earlier in this thread it was asked to
> > combine the dry-run info message into one string with a newline.  But I
> > think this doesn't really fit the message style guidelines.  I suggest
> > to use a primary plus detail style here too.  How about the attached patch?
> >
>
> LGTM.
>

Ditto.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

Split dry-run messages into primary and detail
- 36b1a1e826ea 19 (unreleased) landed
- e3b5817c8b89 master landed
Log a note at program start when running in dry-run mode
- c05dee191125 19 (unreleased) landed
Use USECS_PER_SEC from datatype/timestamp.h
- ad1581d7feae 19 (unreleased) landed
Remove WaitPMResult enum in pg_createsubscriber
- f242dbcede9c 19 (unreleased) landed
pg_createsubscriber: reword dry-run log messages
- c25314d5364e 18.1 landed
- 2648eab3779b 19 (unreleased) landed