Re: row filtering for logical replication
Peter Smith <smithpb2250@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
Here are some review comments for v62-0002 ~~~ 1. src/backend/replication/pgoutput/pgoutput.c - pgoutput_row_filter_update_check + * If the change is to be replicated this function returns true, else false. + * + * Examples: Let's say the old tuple satisfies the row filter but the new tuple + * doesn't. Since the old tuple satisfies, the initial table synchronization + * copied this row (or another method was used to guarantee that there is data + * consistency). However, after the UPDATE the new tuple doesn't satisfy the The word "Examples:" should be on a line by itself; not merged with the 1st example "Let's say...". ~~~ 2. src/backend/replication/pgoutput/pgoutput.c - pgoutput_row_filter_update_check + /* + * For updates, both the new tuple and old tuple needs to be checked + * against the row filter. The new tuple might not have all the replica + * identity columns, in which case it needs to be copied over from the old + * tuple. + */ Typo: "needs to be checked" --> "need to be checked" ~~~ 3. src/backend/replication/pgoutput/pgoutput.c - pgoutput_row_filter_init Missing blank line before a couple of block comments, here: bool pub_no_filter = false; List *schemarelids = NIL; /* * If the publication is FOR ALL TABLES then it is treated the * same as if this table has no row filters (even if for other * publications it does). */ if (pub->alltables) pub_no_filter = true; /* * If the publication is FOR ALL TABLES IN SCHEMA and it overlaps * with the current relation in the same schema then this is also * treated same as if this table has no row filters (even if for * other publications it does). */ else ~~~ 4. src/backend/replication/pgoutput/pgoutput.c - pgoutput_row_filter_init This function was refactored out of the code from pgoutput_row_filter in the v62-0001 patch. So probably there are multiple comments from my earlier v62-0001 review [1] of that pgoutput_row_filter function, that now also apply to this pgoutput_row_filter_init function. ~~~ 5. src/tools/pgindent/typedefs.list - ReorderBufferChangeType Actually, the typedef for ReorderBufferChangeType was added in the 62-0001, so this typedef change should've been done in patch 0001 and it can be removed from patch 0002 ------ [1] https://www.postgresql.org/message-id/CAHut%2BPucFM3Bt-gaTT7Pr-Y_x%2BR0y%3DL7uqbhjPMUsSPhdLhRpA%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia