Horton

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Japin Li <japinli@hotmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas@vondra.me>, "Aya Iwata (Fujitsu)" <iwata.aya@fujitsu.com>, Timur Magomedov <t.magomedov@postgrespro.ru>, shveta malik <shveta.malik@gmail.com>
Date: 2025-08-01T02:21:26Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Mark ItemPointer arguments as const throughout

  2. Reorganize GUC structs

  3. Eliminate XLOG_HEAP2_VISIBLE from vacuum phase III

  4. Update various forward declarations to use typedef

  5. Pathify RHS unique-ification for semijoin planning

  6. Revert "Don't lock partitions pruned by initial pruning"

  7. For inplace update, send nontransactional invalidations.

  8. Remove nearly-unused SizeOfIptrData macro.

On Thu, Jul 31, 2025 at 6:20 PM Japin Li <japinli@hotmail.com> wrote:
>
...
> > 1.
> > I've identified another TRAP failure. Here are the reproduction steps:
> >
> > rm -rf demo
> > initdb -D demo
> > cat <<EOF >>demo/postgresql.auto.conf
> > shared_preload_libraries = 'vci'
> > max_worker_processes = '20'
> > EOF
> >
> > pg_ctl -D demo start
> >
> > cat <<EOF | psql postgres
> > CREATE EXTENSION vci;
> > CREATE TABLE t (id int, info text);
> > CREATE INDEX ON t USING vci (id);
> > INSERT INTO t SELECT id, md5(random()::text) FROM generate_series(1, 1000) id;
> > REINDEX TABLE t;
> > REINDEX TABLE t;
> > EOF
> >
> > The current VCI design doesn't support REINDEX, which is expected. But I've
> > discovered an unexpected issue: running REINDEX on a table a second time causes
> > an assertion failure.
> >
>
> It appears VCI doesn't support reindexing; add_reindex_index_hook() returns
> false, and reindex_index() exits without restoring the security context.
>

Thanks for your fix! This will be included in the next v16 patch set.

======
Kind Regards,
Peter Smith.
Fujitsu Australia