Horton

Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-09-04T04:59:20Z
Lists: pgsql-hackers

Attachments

On Tue, Sep 3, 2024 at 4:12 PM shveta malik <shveta.malik@gmail.com> wrote:
>
...
> Shall we make the change in code-comment as well:
>
> typedef struct ReplicationSlot
> {
> ...
>         /* The time since the slot has become inactive */
>         TimestampTz inactive_since;
> }
>

Hi Shveta,

Yes, I think so. I hadn't bothered to include this in the v1 patch
only because the docs are user-facing, but this code comment isn't.
However, now that you've mentioned it, I made the same change here
also. Thanks. See patch v2.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. Doc: Clarify the `inactive_since` field description.

  2. Change last_inactive_time to inactive_since in pg_replication_slots.