Redundant errdetail prefix "The error was:" in some logical replication messages
Peter Smith <smithpb2250@gmail.com>
From: Peter Smith <smithpb2250@gmail.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-03-30T04:29:35Z
Lists: pgsql-hackers
Attachments
- v1-0001-Remove-redundant-errdetail-The-error-was.patch (application/octet-stream) patch v1-0001
There are a couple of error messages within the logical replication code where the errdetail text includes a prefix of "The error was:" I could not find any other examples in all the PG src which have a similar errdetail prefix like this. The text seems not only redundant, but "The error was: ERROR: " also looks a bit peculiar. e.g. ------ 2021-03-30 14:17:37.567 AEDT [22317] ERROR: could not drop the replication slot "tap_sub" on publisher 2021-03-30 14:17:37.567 AEDT [22317] DETAIL: The error was: ERROR: replication slot "tap_sub" does not exist 2021-03-30 14:17:37.567 AEDT [22317] STATEMENT: DROP SUBSCRIPTION tap_sub; ------ PSA a small patch which simply removes this prefix "The error was:" ------ Kind Regards, Peter Smith. Fujitsu Australia
Commits
-
Improve style of some replication-related error messages.
- 6197db5340b8 14.0 landed