Horton

Re: row filtering for logical replication

Peter Smith <smithpb2250@gmail.com>

View thread
From: Peter Smith <smithpb2250@gmail.com>
To: Euler Taveira <euler@eulerto.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>, vignesh C <vignesh21@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Önder Kalacı <onderkalaci@gmail.com>, japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, David Steele <david@pgmasters.net>, Craig Ringer <craig@2ndquadrant.com>, Amit Langote <amitlangote09@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-21T08:58:54Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Release cache tuple when no longer needed

  2. Add some additional tests for row filters in logical replication.

  3. Fix one of the tests introduced in commit 52e4f0cd47.

  4. Allow specifying row filters for logical replication of tables.

  5. Move scanint8() to numutils.c

  6. Replace Test::More plans with done_testing

  7. Reduce relcache access in WAL sender streaming logical changes

  8. Small cleanups related to PUBLICATION framework code

  9. Add a view to show the stats of subscription workers.

  10. Allow publishing the tables of schema.

  11. Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.

  12. Add PublicationTable and PublicationRelInfo structs

  13. Remove unused argument "txn" in maybe_send_schema().

  14. Add prepare API support for streaming transactions in logical replication.

  15. Unify PostgresNode's new() and get_new_node() methods

  16. Use l*_node() family of functions where appropriate

  17. Add support for prepared transactions to built-in logical replication.

  18. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.

  19. Rename a parse node to be more general

  20. Remove unused column atttypmod from initial tablesync query

  21. SEARCH and CYCLE clauses

Attachments

Here is the v51* patch set:

Main changes from Euler's v50* are
1. Most of Euler's "fixes" patches are now merged back in
2. Patches are then merged per Amit's suggestion [Amit 20/12]
3. Some other review comments are addressed

~~

Phase 1 - Merge the Euler fixes
===============================

v51-0001 (main) <== v50-0001 (main 0001) + v50-0002 (fixes 0001)
- OK, accepted and merged all the "fixes" back into the 0001
- (fixed typos)
- There is a slight disagreement with what the PG docs say about
NULLs, but I will raise a separate comment on -hackers later
(meanwhile, the current PG docs text is from the Euler patch)

v51-0002 (validation) <== v50-0003 (validation 0002) + v50-0004 (fixes 0002)
- OK, accepted and merges all these "fixes" back into the 0002
- (fixed typo)

v51-0003 (new/old) <== v50-0005 (new/old 0003)
- REVERTED to the v49 version of this patch!
- Please see Ajin's explanation why the v49 code was required [Ajin 21/12]

v51-0004 (tab-complete + dump) <== v50-0006 (tab-complete + dump 0004)
- No changes

v51-0005 (for all tables) <== v50-0007 (for all tables 0005) +
v50-0008 (fixes 0005)
- OK, accepted and merged most of these "fixes" back into the 0005
- (fixed typo/grammar)
- Amit requested we not use Euler's new tablesync SQL just yet [Amit 21/12]


Phase 2 - Merge main (Phase 1) patches per Amit suggestion
================================================

v51-0001 (main) <== v51-0001 (main) + v51-0002 (validation) + v51-0005
(for all tables)
- (also combined all the commit comments)

v51-0002 (new/old) <== v51-0003 (new/old)

v51-0005 (tab-complete + dump) <== v51-0004


Review comments (details)
=========================

v51-0001 (main)
- Addressed review comments from Amit. [Amit 20/12] #1,#2,#3,#4

v51-0002 (new/old tuple)
- Includes a patch from Greg (provided internally)

v51-0003 (tab, dump)
- No changes

------
[Amit 20/12] https://www.postgresql.org/message-id/CAA4eK1JJgfEPKYvQAcwGa5jjuiUiQRQZ0Pgo-HF0KFHh-jyNQQ%40mail.gmail.com
[Ajin 21/12] https://www.postgresql.org/message-id/CAFPTHDbfpPNh3GLGjySS%3DAuRfbQPQFNvfiyG1GDQW2kz1yT7Og%40mail.gmail.com
[Amit 21/12] https://www.postgresql.org/message-id/CAA4eK1KwoA5k8v9z9e4ZPN_X%3D1GAmQmsWyauFwZpKiSHqy6eZA%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia