Horton

Re: PostgreSQL 15 minor fixes in protocol.sgml

Peter Smith <smithpb2250@gmail.com>

View thread View on postgr.es
From: Peter Smith <smithpb2250@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ekaterina Kiryanova <e.kiryanova@postgrespro.ru>, pgsql-docs@lists.postgresql.org
Date: 2022-08-03T05:26:25Z
Lists: pgsql-hackers, pgsql-docs

Attachments

On Wed, Aug 3, 2022 at 1:58 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Aug 2, 2022 at 4:28 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Mon, Aug 01, 2022 at 11:00:20PM +0300, Ekaterina Kiryanova wrote:
> >
> > > Another point worth mentioning is that only this file contains the phrase
> > > "two-phase transaction". I believe that "two-phase commit transaction" or
> > > "transaction prepared for two-phase commit" depending on the situation would
> > > be better wording.
> >
> > "Prepare for two-phase commit" may be clearer?
> >
>
> I think we can use just "Prepared transaction" instead. So, the
> message "The user defined GID of the two-phase transaction." can be
> changed to "The user defined GID of the prepared transaction.".
> Similarly, the message "Identifies the message as a two-phase prepared
> transaction message." could be changed to: "Identifies the message as
> a prepared transaction message."
>
> > > And finally, could you please clarify this part?
> > > -- The end LSN of the prepare transaction.
> > > Is it a typo of "prepared transaction"?
>
> I think in this case it should be a "prepared transaction".
>
>
> Thanks for the report and Thanks Michael for including me. I am just
> redirecting it to -hackers so that others involved in this feature
> also can share their views.
>

PSA a patch to modify the descriptions as suggested by Amit.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

Commits

  1. doc: Replace reference to ERRCODE_RAISE_EXCEPTION by "raise_exception"

  2. Improve the protocol message descriptions for 2PC logical replication.

  3. doc: Fix typos in protocol.sgml

  4. Fix inconsistencies and typos in the tree, take 10