oat_post_create expected behavior

Mary Xu <yxu2162@gmail.com>

From: Mary Xu <yxu2162@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2022-06-02T22:37:01Z
Lists: pgsql-hackers

Attachments

Hello,

I was using an object access hook for oat_post_create access while creating
an extension and expected that I would be able to query for the newly
created extension with get_extension_oid(), but it was returning
InvalidOid. However, the same process works for triggers, so I was
wondering what the expected behavior is?
>From the documentation in objectaccess.h, it doesn't mention anything about
CommandCounterIncrement() for POST_CREATE which implied to me that it
wasn't something I would need to worry about.
One option I thought of was this patch where CCI is called before the
access hook so that the new tuple is visible in the hook. Another option
would be to revise the documentation to reflect the expected behavior.

Thanks,

Mary Xu

Commits

  1. Improve comment for OAT_POST_CREATE.