Remove an obsolete comment in gistinsert()

Tender Wang <tndrwang@gmail.com>

From: Tender Wang <tndrwang@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-05T11:48:37Z
Lists: pgsql-hackers

Attachments

Hi,

While learning the GIST codes, I find an obsolete comment in gistinsert ().

itup = gistFormTuple(giststate, r,
                                  values, isnull, true /* size is currently
bogus */ );

The comment "/* size is currently bogus */"  is weird because it follows a
bool variable.
I tracked the commit history.  The original gistFormTuple() prototype is as
below:

extern IndexTuple gistFormTuple(GISTSTATE *giststate,
                        Relation r, Datum *attdata, int *datumsize, bool
*isnull);

you can see this commit  37c8393 to check that.

After 1f7ef54, the function prototype changed, as below:

extern IndexTuple gistFormTuple(GISTSTATE *giststate,
                     Relation r, Datum *attdata, bool *isnull, bool
newValues);

As you can see, "int *datumsize" had been removed, but the comments in
gistbuildCallback() and gistinsert() were not removed together.

By the way, after commit 5edb24a,  the comments in gistbuildCallback() was
removed.
So I think we can now remove the obsolete comment from gistinsert().

-- 
Thanks,
Tender Wang

Commits

  1. Remove an obsolete comment in gistinsert()

  2. Buffering GiST index build algorithm.

  3. Changes

  4. WAL for GiST. It work for online backup and so on, but on