Re: BUG #18568: BUG: Result wrong when do group by on partition table!

Tender Wang <tndrwang@gmail.com>

From: Tender Wang <tndrwang@gmail.com>

To: 狂奔的蜗牛 <1105066510@qq.com>

Cc: pgsql-bugs <pgsql-bugs@lists.postgresql.org>

Date: 2024-08-06T14:37:56Z

Lists: pgsql-bugs

狂奔的蜗牛 <1105066510@qq.com> 于2024年8月6日周二 19:33写道：

> Partkey's collation stored in RelOptInfo->part_scheme, and I use it to fix
> the bug.
> The attachment is my solution!
>

I look through your patch. Some code is not native for PG. For example:

if (nodeTag(groupexpr) == T_RelabelType)

usually, we use IsA() func.

-- 
Tender Wang

Commits

Disallow partitionwise grouping when collations don't match
- 90fe6251c816 18.0 landed
- b6484ca9535e 17.1 landed
- dd2f8ebee221 16.5 landed
- 0a620659c549 15.9 landed
- 96f9b29a3e1e 14.14 landed
- ff65f695c0d3 13.17 landed
- 46d9be5efb1a 12.21 landed
For partitionwise join, match on partcollation, not parttypcoll.
- 2af28e603319 11.0 cited