Re: BUG #18871: Cross-partition MERGE fails with unclear internal error

Tender Wang <tndrwang@gmail.com>

From: Tender Wang <tndrwang@gmail.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Gurjeet Singh <gurjeet@singh.im>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-03-29T10:40:19Z
Lists: pgsql-bugs
Dean Rasheed <dean.a.rasheed@gmail.com> 于2025年3月29日周六 18:20写道:

> On Sat, 29 Mar 2025 at 05:54, Gurjeet Singh <gurjeet@singh.im> wrote:
> >
> > On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote:
> >
> > > In ExecInitPartitionInfo(), it has comments like:
> > >
> > > * This duplicates much of the logic in ExecInitMerge(), so something
> > > * changes there, look here too.
> > >
> > I would've expecetd the comment to be in ExecInitMerge(), asking the
> > reader to look at other places the logic is duplicated.
> >
>
> There already is such a comment a little further up in
> ExecInitMerge(), so I didn't bother repeating it.
>
> I've committed the fix, except that I put the test case in merge.sql,
> since part_abc_view doesn't exist in back branches of
> partition_prune.sql, and it feels more like a MERGE bug anyway.
>

Agree.
Thanks for pushing.

-- 
Thanks,
Tender Wang

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix MERGE with DO NOTHING actions into a partitioned table.