Horton

Re: bug when apply fast default mechanism for adding new column over domain with default value

Tender Wang <tndrwang@gmail.com>

View thread View on postgr.es
From: Tender Wang <tndrwang@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>, jian he <jian.universality@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-04-02T15:24:32Z
Lists: pgsql-hackers 
Tom Lane <tgl@sss.pgh.pa.us> 于2025年4月2日周三 23:15写道：

> Tender Wang <tndrwang@gmail.com> writes:
> > So let's add CommandCounterIncrement() after calling
> StoreAttrMissingVal().
>
> Pushed with minor editorialization.  I thought for a bit about whether
> the CCI call should be inside StoreAttrMissingVal; but its cohorts in
> heap.c don't do their own CCI calls, so this way seems the least
> surprising.
>

Yes, there is no direct call CCI in heap.c.  I also noticed this.
Thanks for pushing.


-- 
Thanks, Tender Wang

Commits

  1. Need to do CommandCounterIncrement after StoreAttrMissingVal.

  2. Simplify some logic around setting pg_attribute.atthasdef.

  3. Remove now-dead code in StoreAttrDefault().

  4. Fix broken handling of domains in atthasmissing logic.