Re: BUG #18568: BUG: Result wrong when do group by on partition table!

jian he <jian.universality@gmail.com> 于2024年8月8日周四 15:51写道：

> On Wed, Aug 7, 2024 at 11:04 PM jian he <jian.universality@gmail.com>
> wrote:
> >
> > On Wed, Aug 7, 2024 at 9:08 PM 狂奔的蜗牛 <1105066510@qq.com> wrote:
> > >
> > > I readd RelabelType to branch in v5 patch, and add case to cover the
> code.
> > >
>
>
> I did some minor adjustments in group_by_has_partkey, also refactored
> the comment.
>

The logic in patch I think no problem. But I don't like the code style.

if (IsA(groupexpr, RelabelType))
     groupexpr = ((RelabelType *) groupexpr)->arg;
if (expr(groupexpr, partexr) && partcoll == groupcoll)
{
...
}

This looks more compact.

By the way, I think we'd better to include test cases together in your
patch, then others can continue
to work based on your patch not need to go back to add the test cases.


-- 
Tender Wang