Horton
Menu

Re: BUG #18866: Running pg_freespace() on views triggers an Abort

Tender Wang <tndrwang@gmail.com>

View thread
From: Tender Wang <tndrwang@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Richard Guo <guofenglinux@gmail.com>, Euler Taveira <euler@eulerto.com>, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2025-03-28T01:59:05Z
Lists: pgsql-bugs 
Tom Lane <tgl@sss.pgh.pa.us> 于2025年3月28日周五 00:01写道：

> Richard Guo <guofenglinux@gmail.com> writes:
> > Not related to this issue but I wonder why blkno is verified after
> > the relation is opened.  It can be verified beforehand, no?
>
> It makes sense to me to check the parameters left-to-right, so
> I think verifying blkno after relation is fine.  It's not like
> there's value in optimizing the failure case.
>
> This does, however, suggest that we ought to check the relkind
> immediately after opening the rel, before the blkno check.
> I'll adjust the patch that way and push.
>

Thanks for pushing.


-- 
Thanks,
Tender Wang

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Prevent assertion failure in contrib/pg_freespacemap.

  2. Don't try to open visibilitymap when analyzing a foreign table