Horton

Re: BUG #18657: Using JSON_OBJECTAGG with volatile function leads to segfault

Tender Wang <tndrwang@gmail.com>

View thread View on postgr.es
From: Tender Wang <tndrwang@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2024-10-16T08:20:41Z
Lists: pgsql-bugs 
Amit Langote <amitlangote09@gmail.com> 于2024年10月16日周三 08:35写道：

> On Wed, Oct 16, 2024 at 9:19 AM Michael Paquier <michael@paquier.xyz>
> wrote:
> > On Tue, Oct 15, 2024 at 11:00:01AM +0000, PG Bug reporting form wrote:
> > > First bad commit for this anomaly is b6e1157e7.
> >
> > Amit, any thoughts?
>
> Will look into it, thanks.
>

Hi,

I debug this issue, and I find that:
after  b6e1157e7,  we shouldn't walk JsonValueExpr.raw_expr in
expression_tree_walker_impl(), which
is called in preprocess_aggrefs().

I try to above solution, no crashed again.


-- 
Thanks,
Tender Wang

Commits

  1. SQL/JSON: Fix some oversights in commit b6e1157e7

  2. Don't include CaseTestExpr in JsonValueExpr.formatted_expr