Horton

Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails

Tender Wang <tndrwang@gmail.com>

View thread View on postgr.es
From: Tender Wang <tndrwang@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Junwang Zhao <zhjwpku@gmail.com>, Jehan-Guillaume de Rorthais <jgdr@dalibo.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Alexander Lakhin <exclusion@gmail.com>, Baehler Thomas SBB CFF FFS <thomas.baehler2@sbb.ch>, Guillaume Lelarge <guillaume@lelarge.info>
Date: 2024-08-20T02:45:47Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@alvh.no-ip.org> 于2024年8月20日周二 10:25写道：

> On 2024-Aug-20, Tender Wang wrote:
>
> > > As I understand, this fix needs to be applied all the way back to 12,
> > > because the overall functionality is that old.  However, in branches 14
> > > and back, the patch doesn't apply cleanly, because of the changes we
> > > made in commit f4566345cf40 :-(  I'm tempted to fix it in branches 15,
> > > 16, 17, master now and potentially backpatch later, to avoid dragging
> > > things along further.  It's taken long enough already.
> >
> > I haven't seen this patch on master.  Is there something that we fotget
> to
> > handle?
>
> I haven't pushed it yet, mostly because of being unsure about not doing
> anything for the oldest branches (14 and back).
>

I only did codes and tests on master. I'm not sure how much complicated it
would be
to fix this issue on branches 14 and back.


-- 
Tender Wang

Commits

  1. Fix some more bugs in foreign keys connecting partitioned tables

  2. Restructure foreign key handling code for ATTACH/DETACH

  3. Create foreign key triggers in partitioned tables too