Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c
Tender Wang <tndrwang@gmail.com>
From: Tender Wang <tndrwang@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-09T11:51:10Z
Lists: pgsql-hackers
Attachments
- 0001-Use-macro-HeapTupleIsValid-to-check-tuple-valid-or-n.patch (text/plain) patch 0001
Hi, While working on another patch, I find that tablecmds.c now has three ways to check the validity of catalog tuples. i. if (tuple != NULL) ii. if (!tuple) iii. if (HeapTupleIsValid(tuple) In tablecmds.c, most checks use macro HeapTupleIsValid. For code readability, I changed the first and the second formats to the third one, e.g., using HeapTupleIsValid. BTW, I searched the other files, some files also have different ways to check the validity of tuples. But the attached patch only focuses on tablecmds.c Any thoughts? -- Thanks, Tender Wang
Commits
-
Remove PointerIsValid()
- a5b35fcedb54 19 (unreleased) landed