Re: BUG #18866: Running pg_freespace() on views triggers an Abort

Tender Wang <tndrwang@gmail.com>

View thread

From: Tender Wang <tndrwang@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: tharakan@gmail.com, pgsql-bugs@lists.postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>

Date: 2025-03-26T01:18:41Z

Lists: pgsql-bugs

Attachments

v2-0001-Don-t-allow-no-storage-relation-to-get-FSM-info.patch (text/plain) patch v2-0001

Tom Lane <tgl@sss.pgh.pa.us> 于2025年3月26日周三 00:37写道：

> Tender Wang <tndrwang@gmail.com> writes:
> > PG Bug reporting form <noreply@postgresql.org> 于2025年3月25日周二 22:42写道：
> >> Passing a view to pg_freespace() triggers an Abort on HEAD.
>
> > I think we can remove the Assert in smgropen().
> > Any thoughts?
>
> That seems like a "solution" that will allow other bugs.  pg_freespace
> should be fixed to verify RELKIND_HAS_STORAGE() before it tries to
> access said storage.
>

Thanks for the advice. Please see the attached patch.


-- 
Thanks,
Tender Wang

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Prevent assertion failure in contrib/pg_freespacemap.
- db8238da4265 13.21 landed
- 5ff827389e77 14.18 landed
- 51d038da8280 17.5 landed
- 4623d71443de 18.0 landed
- 41ed749e48b0 16.9 landed
- 0e86bad38099 15.13 landed
Don't try to open visibilitymap when analyzing a foreign table
- 049ef3398d05 17.0 cited