Re: Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c
Tender Wang <tndrwang@gmail.com>
From: Tender Wang <tndrwang@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-10T08:44:24Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> 于2025年4月10日周四 10:53写道: > On Wed, Apr 09, 2025 at 05:43:24PM +0300, Heikki Linnakangas wrote: > > Agreed. I use both, depending on which mood I'm in. > > Same here, extended to OidIsValid(), HeapTupleIsValid(), XLogRecPtr, > etc., and I tend to prefer such macros, except if consistency of the > surroundings matter most. FWIW, I think that living with the current > state of things to limit backpatch pain is fine. There is no need to > change the existing code as an attempt to apply more standardization > even if one or more code grammar patterns mean the same thing. > OK, makes sense. -- Thanks, Tender Wang
Commits
-
Remove PointerIsValid()
- a5b35fcedb54 19 (unreleased) landed