Re: Standardize the definition of the subtype field of AlterDomainStmt

Peter Eisentraut <peter@eisentraut.org> 于2025年5月28日周三 19:23写道：

> On 27.05.25 05:06, Quan Zongliang wrote:
> > I noticed that the subtype of AlterDomainStmt is directly using
> > constants in the code. It is not conducive to the maintenance and
> > reading of the code. Based on the definition of AlterTableType, use
> > "AD_" as the prefix. Define several macros to replace the original
> > characters.
> > The subtype of AlterTableCmd is defined using an enumeration. The
> > subtypes of AlterDomainStmt are relatively few in number, and the
> > original definition uses characters. These definitions still use
> > characters and maintain the values unchanged. If some plugins or tools
> > are also processing AlterDomainStmt, there will be no errors.
>
> You can still make it an enum and assign the currently in use values to
> the new symbols, like
>
> enum AlterDomainType
> {
>      AD_AlterDefault = 'T',
>      AD_DropNotNull = 'N',
>      ...
>
> I would prefer that.

+1

-- 
Thanks,
Tender Wang