Re: BUG #18314: PARALLEL UNSAFE function does not prevent parallel index build

Tender Wang <tndrwang@gmail.com>

View thread View on postgr.es

From: Tender Wang <tndrwang@gmail.com>

To: jian he <jian.universality@gmail.com>

Cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org

Date: 2024-02-29T07:08:19Z

Lists: pgsql-bugs

Attachments

v2-0001-Fix-parallel-index-build-failed.patch (application/octet-stream) patch v2-0001

jian he <jian.universality@gmail.com> 于2024年2月27日周二 18:17写道：

> Hi.
> one minor  issue.
>
> -RelationGetIndexPredicate(Relation relation)
> +RelationGetIndexPredicate(Relation relation, bool need_modify)
> need_modify name may not be that good IMHO, but so far I can only come
> up with are "raw_expr", "is_raw".
>

Hi jian he,
  I'm sorry for the delayed response.  Thanks for your reviewing, and the
new v2 patch include your advices.

As no others reply to this patch. I would add it to the 2024-03 commitfest.
-- 
Tender Wang
OpenPie:  https://en.openpie.com/

Commits

Revert "Fix parallel-safety check of expressions and predicate for index builds"
- 69e8f9dadb01 12.19 landed
- 70a31629aede 13.15 landed
- 49b971298a9b 14.12 landed
- e82b64a92cf5 15.7 landed
- c46817ee512a 16.3 landed
- 099ca50bd41c 17.0 landed
Fix parallel-safety check of expressions and predicate for index builds
- c0e0174c216b 12.19 landed
- b60d71c202cd 13.15 landed
- 56a8ab2fc6f7 14.12 landed
- 50b5913a87c9 15.7 landed
- 4ec8f7708b6b 16.3 landed
- eae7be600be7 17.0 landed
Ensure we preprocess expressions before checking their volatility.
- 743ddafc7124 17.0 cited