Re: [PATCH] GROUP BY ALL

David Christensen <david@pgguru.net>

From: David Christensen <david@pgguru.net>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: jian he <jian.universality@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, "David G. Johnston" <david.g.johnston@gmail.com>, Jelte Fennema-Nio <postgres@jeltef.nl>

Date: 2025-09-26T18:50:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add GROUP BY ALL.
- ef38a4d9756d 19 (unreleased) landed
Refactor to avoid code duplication in transformPLAssignStmt.
- b0fb2c6aa5a4 19 (unreleased) landed
Fix missed copying of groupDistinct in transformPLAssignStmt.
- b7f6798c056a 16.11 landed
- 9ca79896aba3 15.15 landed
- 78a284b0b8d4 18.1 landed
- 7504d2be9eb4 19 (unreleased) landed
- 3fc9aa5b0233 17.7 landed
- 0be39b4b1a01 14.20 landed

Attachments

v4-0001-Add-GROUP-BY-ALL.patch (application/octet-stream) patch v4-0001

On Fri, Sep 26, 2025 at 12:46 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Some random comments:

[snip]

Great feedback, thanks; attached is v4 which should address these comments.

David