Re: [PATCH] Include application_name in "connection authorized" log message
Don Seiler <don@seiler.us>
From: Don Seiler <don@seiler.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>, pgsql-hackers@lists.postgresql.org
Date: 2018-08-07T13:31:38Z
Lists: pgsql-hackers
On Mon, Jul 30, 2018 at 5:20 AM, Peter Eisentraut < peter.eisentraut@2ndquadrant.com> wrote: > On 13/07/2018 20:20, Don Seiler wrote: > > See attached for latest revision. > > This doesn't compile with SSL enabled because there is a comma missing. > Hmm I'll check this out tonight. Sorry I wasn't able to get to this until now. > This implementation doesn't run the application_name through > check_application_name(), so it could end up logging application_name > values that are otherwise not acceptable. I'm not sure of the best way > to fix that. Is the concern that any user can set their client's application name value to any string they want? Is there a reason we can't call check_application_name() before setting it in the Port struct in postmaster.c? Don. -- Don Seiler www.seiler.us
Commits
-
Add application_name to connection authorized msg
- 8bddc864000f 12.0 landed