Re: Review: Patch to compute Max LSN of Data Pages

Dickson S. Guedes <listas@guedesoft.net>

From: "Dickson S. Guedes" <listas@guedesoft.net>
To: Amit kapila <amit.kapila@huawei.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2013-01-20T11:27:37Z
Lists: pgsql-hackers
2013/1/20 Amit kapila <amit.kapila@huawei.com>:
> On Sunday, January 20, 2013 4:04 AM Dickson S. Guedes wrote:
> 2013/1/18 Amit kapila <amit.kapila@huawei.com>:
>>> Please find the rebased Patch for Compute MAX LSN.
>
>>The function 'remove_parent_refernces' couldn't be called
>>'remove_parent_references' ?
>
> Shall fix this.
>
>> Why not an extension in PGXN instead of a contrib?
>
> This functionality has similarity to pg_resetxlog, so we thought of putting it either in bin or in contrib.
> Finally based on suggestions from other community members, we have added to contrib.

Indeed.

-- 
Dickson S. Guedes
mail/xmpp: guedes@guedesoft.net - skype: guediz
http://github.com/guedes - http://guedesoft.net
http://www.postgresql.org.br