Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
solaimurugan vellaipandiyan <drsolaimurugan.v@gmail.com>
From: solaimurugan vellaipandiyan <drsolaimurugan.v@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <johncnaylorls@gmail.com>,
Aleksander Alekseev <aleksander@tigerdata.com>, Payal Singh <payals1@umbc.edu>, pgsql-hackers@lists.postgresql.org
Date: 2026-05-11T11:04:20Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
De-obfuscate the comment in tsrank.c's calc_rank_or().
- 163f20ca12a9 19 (unreleased) landed
Hi Tom, I tested the proposed v8 patch on current HEAD. I reran pgindent on files like contrib/seg/seg.c and src/port/inet_aton.c, and the updated formatting looked more consistent overall. I also checked that repeated pgindent runs did not introduce additional changes, and git diff --check was clean. Additionally, the single-line comment case now stays unchanged as expected. Overall, the new normalization behavior looks much cleaner and more uniform in my testing. Regards, Solaimurugan V