Horton

Re: auxiliary processes in pg_stat_ssl

Euler Taveira <euler@timbira.com.br>

View thread
From: Euler Taveira <euler@timbira.com.br>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-04T15:39:49Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_stat_activity: document client_port being null

  2. pg_stat_{ssl,gssapi}: Show only processes with connections

Attachments

Em qua., 4 de set. de 2019 às 12:15, Alvaro Herrera
<alvherre@2ndquadrant.com> escreveu:
>
> I just noticed that we list auxiliary processes in pg_stat_ssl:
>
> 55432 13devel 28627=# select * from pg_stat_ssl ;
>   pid  │ ssl │ version │         cipher         │ bits │ compression │ client_dn │ client_serial │ issuer_dn
> ───────┼─────┼─────────┼────────────────────────┼──────┼─────────────┼───────────┼───────────────┼───────────
>  28618 │ f   │         │                        │      │             │           │               │
>  28620 │ f   │         │                        │      │             │           │               │
>  28627 │ t   │ TLSv1.3 │ TLS_AES_256_GCM_SHA384 │  256 │ f           │           │               │
>  28616 │ f   │         │                        │      │             │           │               │
>  28615 │ f   │         │                        │      │             │           │               │
>  28617 │ f   │         │                        │      │             │           │               │
> (6 filas)
>
> 55432 13devel 28627=# select pid, backend_type from pg_stat_activity ;
>   pid  │         backend_type
> ───────┼──────────────────────────────
>  28618 │ autovacuum launcher
>  28620 │ logical replication launcher
>  28627 │ client backend
>  28616 │ background writer
>  28615 │ checkpointer
>  28617 │ walwriter
> (6 filas)
>
> But this seems pointless.  Should we not hide those?  Seems this only
> happened as an unintended side-effect of fc70a4b0df38.  It appears to me
> that we should redefine that view to restrict backend_type that's
> 'client backend' (maybe include 'wal receiver'/'wal sender' also, not
> sure.)
>
Yep, it is pointless. BackendType that open connections to server are:
autovacuum worker, client backend, background worker, wal sender. I
also notice that pg_stat_gssapi is in the same boat as pg_stat_ssl and
we should constraint the rows to backend types that open connections.
I'm attaching a patch to list only connections in those system views.



--
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento