Thread
Commits
-
Fix typo in comment.
- 99139c46cbf2 19 (unreleased) landed
-
Fixed a minor typo in code comment
厉超 <lic@highgo.com> — 2025-08-05T23:10:32Z
Hi, I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it. I ran a basic test of “make check” and the test passed.  Chao Li (Evan) -------------------- HighGo Infra. Software Inc. https://www.highgo.com/
-
Re: Fixed a minor typo in code comment
厉超 <lic@highgo.com> — 2025-08-05T23:26:35Z
Looks like the attachment was missing from the original email, adding the attachment. -----原始邮件----- 发件人:"Chao Li" <lic@highgo.com> 发送时间:2025-08-06 07:10:32 (星期三) 收件人: pgsql-hackers@postgresql.org 主题: Fixed a minor typo in code comment Hi, I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it. I ran a basic test of “make check” and the test passed. Chao Li (Evan) -------------------- HighGo Infra. Software Inc. https://www.highgo.com/
-
Re: Fixed a minor typo in code comment
Fujii Masao <masao.fujii@gmail.com> — 2025-08-06T04:11:16Z
On Wed, Aug 6, 2025 at 8:11 AM Chao Li <lic@highgo.com> wrote: > > Hi, > > I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it. > > I ran a basic test of “make check” and the test passed. Thanks for the patch! LGTM. The comment doesn't follow our usual style. How about adjusting it to match our typical format while fixing the typo? I've attached the updated version of the patch. Regards, -- Fujii Masao
-
Re: Fixed a minor typo in code comment
厉超 <lic@highgo.com> — 2025-08-06T04:17:24Z
I am fine with that, and thanks for the v2 patch. Chao Li (Evan) -------------------- HighGo Infra. Software Inc. https://www.highgo.com/ > On Aug 6, 2025, at 12:11, Fujii Masao <masao.fujii@gmail.com> wrote: > > On Wed, Aug 6, 2025 at 8:11 AM Chao Li <lic@highgo.com> wrote: >> >> Hi, >> >> I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it. >> >> I ran a basic test of “make check” and the test passed. > > Thanks for the patch! LGTM. > > The comment doesn't follow our usual style. How about adjusting it to > match our typical format while fixing the typo? I've attached > the updated version of the patch. > > Regards, > > -- > Fujii Masao > <v2-0001-Fix-typo-in-comment.patch>
-
Re: Fixed a minor typo in code comment
Fujii Masao <masao.fujii@gmail.com> — 2025-08-06T13:53:41Z
On Wed, Aug 6, 2025 at 1:17 PM Chao Li <lic@highgo.com> wrote: > > I am fine with that, and thanks for the v2 patch. I've pushed the patch. Thanks! Regards, -- Fujii Masao