Thread

Re: [PATCH] Fix psql tab completion for REPACK boolean options

Fujii Masao <masao.fujii@gmail.com> — 2026-05-18T04:17:13Z

On Fri, May 15, 2026 at 11:32 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> > Second, when the same option is specified multiple times, the last value
> > is not always honored. In particular, if any occurrence sets an option to ON,
> > the option remains enabled even when the final setting is OFF.
> >
> > I think these are bugs, and the attached patch fixes them. Thoughts?
>
> I agree that these are bugs.  The patch looks good to me on a cursory
> look, though I didn't actually test it.

Thanks for the review! I've tested it again and then pushed it.

Regards,

-- 
Fujii Masao