Horton
Menu

Re: Use proc_exit() in WalRcvWaitForStartPosition

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Xuneng Zhou <xunengzhou@gmail.com>, Andreas Karlsson <andreas@proxel.se>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-04-10T14:17:29Z
Lists: pgsql-hackers 
On Fri, Apr 10, 2026 at 4:07 PM Chao Li <li.evan.chao@gmail.com> wrote:
> PFA v2 - updated header comment of walreceive.c. I tried to avoid mentioning the exact exit value in the comment, so I just changed “exit(0)” to “terminate”.

Thanks for updating the patch!

"termination instructs XXX to terminate" sounds a bit redundant. How
about saying
"to ereport(FATAL)" instead of “to terminate”?

Regards,


-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use proc_exit() for walreceiver exit in WalRcvWaitForStartPosition()