Horton
Menu

Re: Suggestion to add --continue-client-on-abort option to pgbench

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Rintaro Ikeda <ikedarintarof@oss.nttdata.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>, Chao Li <li.evan.chao@gmail.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "slpmcf@gmail.com" <slpmcf@gmail.com>, "boekewurm+postgres@gmail.com" <boekewurm+postgres@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Srinath Reddy Sadipiralla <srinath2133@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2025-10-28T16:00:25Z
Lists: pgsql-hackers

Attachments

On Mon, Oct 27, 2025 at 6:13 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> One approach to address this issue is to keep calling PQgetResult() until
> it returns NULL, and then check the connection status when getSQLErrorStatus()
> determines the error state. If the connection status is CONNECTION_BAD
> at that point, we can treat it as a connection failure and stop processing
> even when --continue-on-error is specified. Attached is a WIP patch
> implementing this idea based on the v17 patch. It still needs more testing,
> review, and possibly documentation updates.
>
> Another option would be to explicitly list all SQLSTATE codes (e.g., 57P01)
> that should prevent continued processing, even with --continue-on-error,
> inside getSQLErrorStatus(). However, maintaining such a list would be
> cumbersome, so I believe the first approach is preferable. Thought?

Nagata-san let me know off-list that there was the case where the previous
patch didn't work correctly in pipeline mode. I've updated the patch so that
--continue-on-error now works properly in that mode, and also revised
the commit message. Updated patch attached.

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode.

  2. pgbench: Add --continue-on-error option.

  3. Fix "inconsistent DLL linkage" warning on Windows MSVC

  4. pgbench: Fix error reporting in readCommandResponse().

  5. pgbench: Fix assertion failure with retriable errors in pipeline mode.

  6. Allow pgbench to retry in some cases.