Re: pg_stat_statements: calls under-estimation propagation
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Peter Geoghegan <pg@heroku.com>
Cc: Sameer Thakur <samthakur74@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>,
Tom Lane <tgl@sss.pgh.pa.us>
Date: 2013-12-06T19:02:55Z
Lists: pgsql-hackers
On Sun, Nov 24, 2013 at 10:58 AM, Peter Geoghegan <pg@heroku.com> wrote: > On Mon, Nov 18, 2013 at 1:54 AM, Sameer Thakur <samthakur74@gmail.com> wrote: >> Please find v10 of patch attached. This patch addresses following >> review comments > > I've cleaned this up - revision attached - and marked it "ready for committer". > > I decided that queryid should be of type oid, not bigint. This is > arguably a slight abuse of notation, but since ultimately Oids are > just abstract object identifiers (so say the docs), but also because > there is no other convenient, minimal way of representing unsigned > 32-bit integers in the view that I'm aware of, I'm inclined to think > that it's appropriate. There seems to be no problem even if we use bigint as the type of unsigned 32-bit integer like queryid. For example, txid_current() returns the transaction ID, i.e., unsigned 32-bit integer, as bigint. Could you tell me what the problem is when using bigint for queryid? Regards, -- Fujii Masao
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Improve management of "sticky" entries in contrib/pg_stat_statements.
- d5375491f8e3 9.2.0 cited