Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

Fujii Masao <masao.fujii@gmail.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: li.evan.chao@gmail.com, jian.universality@gmail.com, pgsql-hackers@postgresql.org
Date: 2026-06-18T16:14:47Z
Lists: pgsql-hackers 
On Thu, Jun 18, 2026 at 5:28 PM Tatsuo Ishii <ishii@postgresql.org> wrote:
>
> > I've updated the patch accordingly.
> >
> > I removed "is" from "RESPECT/IGNORE NULLS is specified" to match other
> > similar error messages, which use the form "XXX specified, ...".
> >
> > + if (ignore_nulls != NO_NULLTREATMENT)
> > + ereport(ERROR,
> > + (errcode(ERRCODE_WRONG_OBJECT_TYPE),
>
> The errcode field can start without a parenthesis:
>
> errcode(ERRCODE_WRONG_OBJECT_TYPE),

Yes, but other similar ereport() calls in parse_func.c also start
the errcode field with a parenthesis, so I followed the same style
here.

Regards,

-- 
Fujii Masao

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.