Horton

Thread

Commits

  1. Fix the name of the first WAL segment file, in docs.

  2. Bootstrap WAL to begin at segment logid=0 logseg=1 (000000010000000000000001)

  1. First WAL segment file that initdb creates

    Fujii Masao <masao.fujii@gmail.com> — 2019-10-09T05:48:50Z

    Hi,

There is the following description in wal.sgml.

    Segment
    files are given ever-increasing numbers as names, starting at
    <filename>000000010000000000000000</filename>.

But the first WAL segment file that initdb creates is 000000010000000000000001
not 000000010000000000000000. This change was caused by old commit 8c843fff2d,
but seems the documentation had not been updated unfortunately a long time.
Attached patch replaces 000000010000000000000000 with 000000010000000000000001
in the above description.

This patch needs to be back-patched to all the supported versions.

Regards,

-- 
Fujii Masao

  2. Re: First WAL segment file that initdb creates

    David Zhang <david.zhang@highgo.ca> — 2020-02-18T20:26:43Z

    The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            tested, passed

The issue has been verified using below steps:
1. $ initdb -D /home/test/PG122DATA/data
2. $ ls -l /home/test/PG122DATA/data/pg_wal/
total 16388
-rw------- 1 test test 16777216 Feb 18 12:07 000000010000000000000001
drwx------ 2 test test     4096 Feb 18 12:07 archive_status

The first WAL segment file created by initdb is "000000010000000000000001", not "000000010000000000000000".

  3. Re: First WAL segment file that initdb creates

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-03-03T03:29:12Z

    
On 2020/02/19 5:26, David Zhang wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  not tested
> Implements feature:       not tested
> Spec compliant:           not tested
> Documentation:            tested, passed
> 
> The issue has been verified using below steps:
> 1. $ initdb -D /home/test/PG122DATA/data
> 2. $ ls -l /home/test/PG122DATA/data/pg_wal/
> total 16388
> -rw------- 1 test test 16777216 Feb 18 12:07 000000010000000000000001
> drwx------ 2 test test     4096 Feb 18 12:07 archive_status
> 
> The first WAL segment file created by initdb is "000000010000000000000001", not "000000010000000000000000".

Thanks for the test! I pushed the patch.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters