Re: incorrect handling of the timeout in pg_receivexlog

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Magnus Hagander <magnus@hagander.net>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2012-05-23T18:11:25Z

Lists: pgsql-hackers

Attachments

pqfinish_before_exit_v1.patch (application/octet-stream) patch v1

On Tue, May 22, 2012 at 11:04 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Mon, May 14, 2012 at 2:24 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Fri, May 11, 2012 at 11:43 PM, Magnus Hagander <magnus@hagander.net> wrote:
>>> Should we go down the easy way and just reject connections when the flag is
>>> mismatching between the client and the server (trivial to do - see the
>>> attached patch)?
>>
>> +       char       *tmpparam;
>>
>> You forgot to add "const" before "char", which causes a compile-time warning.
>
> I went ahead and committed this, with this fix and a slight change to
> the message text.

Thanks!

> Hope that's OK with everyone...

What about calling PQfinish() before exit() to avoid "unexpected EOF
connection" error?
Patch attached.

Regards,

-- 
Fujii Masao