Re: Invalid primary_slot_name triggers warnings in all processes on reload
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Álvaro Herrera <alvherre@kurilemu.de>, Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-22T13:31:22Z
Lists: pgsql-hackers
Attachments
- v7-0001-Avoid-double-translation-of-messages-for-invalid-.patch (application/octet-stream) patch v7-0001
On Wed, Oct 22, 2025 at 12:52 PM Fujii Masao <masao.fujii@gmail.com> wrote: > So let's push the current patch, including only the cosmetic indentation > changes suggested by Hayato-san. I've pushed the patch. Thanks! Attached is the rebased version of the patch I shared earlier, which adds GUC_check_errmsg_internal(), GUC_check_errdetail_internal(), and GUC_check_errhint_internal(). These functions work like their counterparts (e.g., GUC_check_errmsg()) but skip translation. The patch also updates the check hook for primary_slot_name to use these new functions when handling already-translated error messages. If we apply this patch, I'm thinking to push it to master only. Regards, -- Fujii Masao
Commits
-
Make invalid primary_slot_name follow standard GUC error reporting.
- b00a16baeb2a 13.23 landed
- f106f53df6f5 14.20 landed
- caf529aba22d 15.15 landed
- 4fd916eab99c 16.11 landed
- 1db2870bb5ab 17.7 landed
- 6ff7ba9fe525 18.1 landed
- f33e60a53a9c 19 (unreleased) landed