Re: client_connection_check_interval default value
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Hüseyin Demir <huseyin.d3r@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-03-16T09:21:50Z
Lists: pgsql-hackers
On Mon, Mar 16, 2026 at 10:37 AM Chao Li <li.evan.chao@gmail.com> wrote: > V2 overall looks good to me. > > A small comment is about the variable name logged_lock_waits that sounds like “count of waits”, I would suggest “lock_wait_logged”. But I see that the name follows the naming convention of the existing variable logged_recovery_conflict, so maybe just rename to logged_lock_wait (remove the “s”). > TBH I'm not sure whether renaming the variable that way is a good idea, but I don't have a strong opinion about this. So I renamed it to logged_lock_wait (i.e., removed the trailing "s"). I've pushed the patch. Thanks! Regards, -- Fujii Masao
Commits
-
Add TAP tests for log_lock_waits
- ca2b5443e2dc 19 (unreleased) landed
-
Add tests for lock statistics, take two
- 557a9f1e3e62 19 (unreleased) cited
-
Ensure "still waiting on lock" message is logged only once per wait.
- fd6ecbfa75ff 19 (unreleased) landed