Horton
Menu

Re: pg_test_timing: fix unit typo and widen diff type

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: "wang.xiao.peng" <wxp_728@163.com>, lukas@fittl.com, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Hannu Krosing <hannuk@google.com>
Date: 2026-04-22T16:11:53Z
Lists: pgsql-hackers 
On Wed, Apr 22, 2026 at 5:58 PM Chao Li <li.evan.chao@gmail.com> wrote:
> PFA v4:
>
> * 0001 unchanged from v3.
> * 0002 changed size of histogram[] 64.

Thanks for updating the patch!

Since patch 0001 is a bug fix, it should be backpatched to the supported stable
branches. However, in v19 the unit should be changed like s/ms/ns, while in v18
and earlier s/ms/us, since those older branches report the diff in microseconds.
Right?

Patch 0002 looks more like an improvement than a bug fix, so we should probably
wait for the next CommitFest before committing it. Thoughts?

Regards,


-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_test_timing: store timing deltas in int64

  2. pg_test_timing: fix unit in backward-clock warning