Re: Addition of %b/backend_type in log_line_prefix of TAP test logs

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-05-21T02:41:18Z
Lists: pgsql-hackers
On Wed, May 21, 2025 at 8:51 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> Hi all,
>
> While navigating through the logs in the CI, the buildfarm, or even my
> own machine, I've found myself spending a lot of time looking at
> very specific log entries to find out the PID of a specific process,
> sometimes mistaking a normal backend vs a logical WAL sender while
> looking for a PID, or just looking for an auxiliary process.
>
> I'd like to suggest the following change in Cluster.pm:
> -   print $conf "log_line_prefix = '%m [%p] %q%a '\n";
> +   print $conf "log_line_prefix = '%m [%b,%p] %q%a '\n";

+1 to this change.

Since pg_regress uses log_line_prefix = '%m %b[%p] %q%a ',
isn't it better to use the same setting in TAP tests as well?

Regards,

-- 
Fujii Masao



Commits

  1. Align log_line_prefix in CI and TAP tests with pg_regress.c