Horton
Menu

Re: Log prefix missing for subscriber log messages received from publisher

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, vignesh C <vignesh21@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-22T13:13:31Z
Lists: pgsql-hackers 
On Tue, Jul 22, 2025 at 9:49 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Jul-22, Fujii Masao wrote:
>
> > On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> > > Oh yeah, I should have remembered this -- see commit 213c959a294d.  Feel
> > > free to do away with the whole translation thing ... doesn't seem worth
> > > spending more time on it.
> >
> > Yes! The attached patch removes the translation marker and the
> > gettext_noop() calls I recently added.
>
> LGTM.

Thanks for the review!


> > > We should still remove all gettext_noop() markers in contrib :-)
> >
> > You mean to remove gettext_noop() also from basic_archive.c?
>
> Yes, it's useless and misleading.  Feel free to do it in the same commit ...

I've included that change in the patch and pushed it. Thanks!

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove translation marker from libpq-be-fe-helpers.h.

  2. Log remote NOTICE, WARNING, and similar messages using ereport().

  3. Remove translation markers from libpq-be-fe-helpers.h