Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

Fujii Masao <masao.fujii@gmail.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Tatsuo Ishii <ishii@postgresql.org>, jian.universality@gmail.com, pgsql-hackers@postgresql.org
Date: 2026-06-23T05:55:57Z
Lists: pgsql-hackers 
On Fri, Jun 19, 2026 at 1:12 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Jun 18, 2026 at 11:46 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> >
> > Hello,
> >
> > I would dearly appreciate it if you could make these errors in this
> > style:
> >
> > ereport(ERROR,
> >         (errcode(ERRCODE_WRONG_OBJECT_TYPE),
> >         /* translator: first %s is a CREATE FUNCTION clause, eg. "IGNORE NULLS" */
> >          errmsg("%s specified, but %s is not a window function",
> >          "RESPECT/IGNORE NULLS", NameListToString(funcname)),
> >          parser_errposition(pstate, location)));
> >
> > to avoid keeping the clause name in the translatable string.
>
> Thanks for the suggestion! I've updated the patch accordingly.
> Patch attached.

Barring any objections, I will commit the patch.

Regards,

-- 
Fujii Masao

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.