Horton
Menu

Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Nisha Moond <nisha.moond412@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-08T02:39:43Z
Lists: pgsql-hackers 
On Tue, Apr 7, 2026 at 12:48 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> I agree with this line of reasoning here or in general as well but
> personally I am a bit hesitant to back patch changes which are not
> mandatory. In this particular case, I don't see any problem with
> backpatching the part of code you want to backpatch, so I leave it to
> your judgement.

Thanks for the comment!

I decided to backpatch commit 1362bc33e02. Although pg_sync_replication_slots()
lacks retry logic in v17 and v18 and is therefore less likely to block
promotion, the issue still exists in those versions.

Given that, it seemed worthwhile to backpatch the change and fix cases where
both the slotsync worker and pg_sync_replication_slots() can block promotion
when stuck in a wait.

I've pushed and backpatched the patch. Thanks!

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Update .abi-compliance-history for change to enum ProcSignalReason

  2. Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalReason

  3. Fix slotsync worker blocking promotion when stuck in wait

  4. Add retry logic to pg_sync_replication_slots().

  5. Enhance slot synchronization API to respect promotion signal.