Re: [bug fix] pg_rewind takes long time because it mistakenly copies data files

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>
To: "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>
Cc: Michael Paquier <michael@paquier.xyz>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-03-05T17:14:56Z
Lists: pgsql-hackers
On Wed, Feb 28, 2018 at 3:58 PM, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> From: Michael Paquier [mailto:michael@paquier.xyz]
>> So I would propose to just do that later.  I have looked a second time at
>> your patch, attached is the set of tests I have run:
>
> Thanks so much, that has helped me a lot!
>
>> I have one small comment though.  The comment block at the beginning of
>> isRelDataFile() refers to "pg_tblspc/<tblspc oid>/PG_9.4_201403261/".
>> Could you switch that to "pg_tblspc/<tblspc oid>/<tblspc version>"?
>> That's not directly the fault of your patch, but as long as we are on it..
>
> Done, thanks again for marking the CF entry.

Thanks for the patch! Pushed.

Regards,

-- 
Fujii Masao


Commits

  1. Fix pg_rewind to handle relation data files in tablespaces properly.