Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Simon Riggs <simon@2ndquadrant.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2012-01-13T04:18:40Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Send new protocol keepalive messages to standby servers.
- 64233902d22b 9.2.0 cited

On Fri, Jan 13, 2012 at 4:19 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Thu, Jan 12, 2012 at 10:37 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Thu, Jan 12, 2012 at 5:53 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>> PrimaryKeepaliveMessage is a message type that uses WalSndrMessage.
>>> That message type is only sent when the WalSndr is quiet, so what is
>>> the difference, in that case?
>>
>> Oh, you are right. There is no difference.
>
> Here are the changes we discussed. Further comments before commit?

Can you add the test for avoiding useless call of GetReplicationApplyDelay()
and GetReplicationTransferLatency()?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center