Horton

Re: Online base backup from the hot-standby

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>, ssinger_pg@sympatico.ca, simon@2ndquadrant.com, pgsql-hackers@postgresql.org, robertmhaas@gmail.com, cedric.villemain.debian@gmail.com
Date: 2011-10-25T11:54:58Z
Lists: pgsql-hackers 
On Tue, Oct 25, 2011 at 7:19 PM, Magnus Hagander <magnus@hagander.net> wrote:
> I don't think we should necessarily give up completely. But doing a
> pg_basebackup way *first* seems reasonable - because it's going to be
> the easiest one to "get right", given that we have more control there.
> Doesn't mean we shouldn't extend it in the future...

Agreed. The question is -- how far should we change pg_basebackup to
"get right"? I think it's not difficult to change it so that it backs up
the control file at the end. But eliminating the need for full_page_writes=on
seems not easy. No? So I'm not inclined to do that in at least first commit.
Otherwise, I'm afraid the patch would become huge.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center