Horton
Menu

Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-16T04:11:52Z
Lists: pgsql-hackers 
On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21@gmail.com> wrote:
> I felt these also should be updated, the attached v2 version patch
> includes the changes for the same.

Thanks for updating the patch!

-       applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
+       applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?

XLogRecPtrIsValid() should be used here, instead?

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use XLogRecPtrIsValid() consistently for WAL position checks

  2. Use XLogRecPtrIsValid() in various places